From 5fee1a9b408d7ac4f5113fb75630e54cb2a5ff2e Mon Sep 17 00:00:00 2001 From: Till Wegmueller Date: Sat, 4 Apr 2026 19:03:14 +0200 Subject: [PATCH] Fix review findings: output transform, resize TODO, import aliases - Change Transform::Flipped180 to Transform::Normal for virtual output - Add TODO comment on resize handler for future output mode update - Rename misleading JsonPointer* import aliases to *Trait --- crates/wrsrvd/src/main.rs | 5 ++++- crates/wrsrvd/src/state.rs | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/crates/wrsrvd/src/main.rs b/crates/wrsrvd/src/main.rs index e5f855e..d8ec2c9 100644 --- a/crates/wrsrvd/src/main.rs +++ b/crates/wrsrvd/src/main.rs @@ -68,7 +68,7 @@ fn main() -> Result<()> { size: window_size, refresh: 60_000, // 60 Hz in millihertz }; - output.change_current_state(Some(mode), Some(Transform::Flipped180), None, None); + output.change_current_state(Some(mode), Some(Transform::Normal), None, None); output.set_preferred(mode); // Create the global output for Wayland clients to bind to. @@ -123,6 +123,9 @@ fn main() -> Result<()> { loop_handle .insert_source(winit_event_loop, move |event, _, data| match event { WinitEvent::Resized { size, scale_factor } => { + // TODO: Update output mode, damage tracker, and space mapping + // to reflect the new window size. Currently the compositor + // continues rendering at the original size after resize. info!(?size, scale_factor, "window resized"); } WinitEvent::Focus(focused) => { diff --git a/crates/wrsrvd/src/state.rs b/crates/wrsrvd/src/state.rs index ab36eb3..1b7d130 100644 --- a/crates/wrsrvd/src/state.rs +++ b/crates/wrsrvd/src/state.rs @@ -2,8 +2,8 @@ use smithay::{ backend::input::{ AbsolutePositionEvent, Axis, AxisSource, ButtonState, Event as InputEventTrait, InputBackend, InputEvent, KeyboardKeyEvent, - PointerAxisEvent as JsonPointerAxisEvent, - PointerButtonEvent as JsonPointerButtonEvent, + PointerAxisEvent as PointerAxisEventTrait, + PointerButtonEvent as PointerButtonEventTrait, }, desktop::{Space, WindowSurfaceType}, input::{